Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print detailed error when installing package. #1314

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

harryge00
Copy link
Contributor

@harryge00 harryge00 commented Jan 27, 2020

What this PR does / why we need it:

Fixes #1269
Print detailed error when resolver cannot find the specific package or version.

  1. When install a non-existent operator version:
# ./bin/kubectl-kudo-original install kafka --operator-version=8.0.0        
Error: failed to resolve operator package for: kafka resolver: unable to find packages for kafka
# ./bin/kubectl-kudo-new-fix install kafka --operator-version=8.0.0    
Error: failed to resolve operator package for: kafka getting kafka in index file: no operator version found for kafka-8.0.0
  1. When install a non-existent package
# ./bin/kubectl-kudo-original install non-exist     
Error: failed to resolve operator package for: non-exist resolver: unable to find packages for non-exist
# ./bin/kubectl-kudo-new-fix install non-exist  
Error: failed to resolve operator package for: non-exist getting non-exist in index file: no operator found for: non-exist

Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🚢

@harryge00
Copy link
Contributor Author

harryge00 commented Jan 27, 2020

I just removed resolver: unable to find packages for because it seems a bit duplicate when detailed error is returned.

Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@kensipe kensipe merged commit 8f66e34 into kudobuilder:master Jan 28, 2020
ANeumann82 pushed a commit that referenced this pull request Feb 13, 2020
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
runyontr pushed a commit that referenced this pull request Mar 11, 2020
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect message when the operator package version doesn't exist
3 participants