Error out in instance controller when a parameter has an undefined plan trigger #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error out in instance controller when a parameter has an undefined plan trigger Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
porridge
approved these changes
Feb 10, 2020
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
added a commit
that referenced
this pull request
Feb 13, 2020
…an trigger (#1336) * Verify plans are referenced and referenced plans are defined * error out in instance controller when a parameter has an undefined plan trigger Signed-off-by: Andreas Neumann <aneumann@mesosphere.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
…an trigger (#1336) * Verify plans are referenced and referenced plans are defined * error out in instance controller when a parameter has an undefined plan trigger Signed-off-by: Andreas Neumann <aneumann@mesosphere.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify plans are referenced and referenced plans are defined
Signed-off-by: Andreas Neumann aneumann@mesosphere.com
Fixes #1268