Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error out in instance webhook when a parameter has an undefined plan trigger #1345

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

zen-dog
Copy link
Contributor

@zen-dog zen-dog commented Feb 13, 2020

Summary:
This is a followup to #1336 which verified that triggered plans are actually defined in the OV. This PR adds this logic to the instance webhook.

Fixes #1268

Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com

…trigger

Summary:
This is a followup to #1336 which verified that triggered plans are actually defined in the OV. This PR adds this logic to the instance webhook.

Fixes #1268

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
@zen-dog zen-dog merged commit 9aa79df into master Feb 17, 2020
@zen-dog zen-dog deleted the ad/webhook-verify-triggered-plan branch February 17, 2020 09:52
runyontr pushed a commit that referenced this pull request Mar 11, 2020
…trigger (#1345)

Summary:
This is a followup to #1336 which verified that triggered plans are actually defined in the OV. This PR adds this logic to the instance webhook.

Fixes #1268

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly specifying nonexistent trigger plan is silently treated as deploy
2 participants