Use full filename and path to check for operatorFile and paramsFile #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of using only suffix Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
zen-dog
reviewed
Feb 13, 2020
zen-dog
reviewed
Feb 13, 2020
| expectedError error | ||
| }{ | ||
| {"operator.yaml", validOperator, true, false, false, nil}, | ||
| {"params.yaml", validParams, false, true, false, nil}, |
There was a problem hiding this comment.
a test case {"/foo/bar/operator.yaml", validOperator, true, false, false, nil}, is failing on this branch.
There was a problem hiding this comment.
See latest commit: I think the parser should only handle package-relative paths, not absolute file system paths. I've added code that normalises the paths passed into the parser.
There was a problem hiding this comment.
Also added a comment to parsePackageFile
zen-dog
reviewed
Feb 13, 2020
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
…1344) * Use full filename and path to check for operatorFile and paramsFile instead of using only suffix * Use only relative paths in package parser Signed-off-by: Andreas Neumann <aneumann@mesosphere.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andreas Neumann aneumann@mesosphere.com
What this PR does / why we need it:
Fixes #1343