Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEP 0025] Template toYaml function #1363

Merged
merged 3 commits into from
Mar 2, 2020
Merged

[KEP 0025] Template toYaml function #1363

merged 3 commits into from
Mar 2, 2020

Conversation

porridge
Copy link
Member

What this PR does / why we need it:

This KEP describes addition of a function called toYaml for use in the operator templates.

Signed-off-by: Marcin Owsiany mowsiany@D2iQ.com

Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
@nfnt
Copy link
Member

nfnt commented Feb 25, 2020

Do we need a KEP for this? IMO, the motivation is already covered in #1221. And adding a toYAML function that marshals an interface{} into YAML is maybe 10 lines of code. The only thing needed is an implementation of KEP-24, that allows parameter values that are more complex that string.

@porridge
Copy link
Member Author

Do we need a KEP for this?

So, your comment on KEP-24 that toYaml should not be a part of that KEP somehow made me think that it's big enough to warrant its own KEP. Then the way I read the guidelines I thought that it might be borderline, but does not hurt. So I just did it :-P

If you think it's a no-brainer please just hit the approve button 🎉 :-)

@nfnt
Copy link
Member

nfnt commented Feb 26, 2020

@porridge You're right and I don't want to discourage anyone from creating new KEPs. Just be aware that a KEP has a bit more overhead :)

Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
@porridge porridge merged commit 80c8105 into master Mar 2, 2020
@porridge porridge deleted the kep-25 branch March 2, 2020 09:06
runyontr pushed a commit that referenced this pull request Mar 11, 2020
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
@porridge porridge added the kep/25 Template function toYaml label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kep/25 Template function toYaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants