Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide configuration support for nodeSelector, podAnnotations, and resources #1221

Closed
akirillov opened this issue Dec 23, 2019 · 3 comments
Closed
Labels
kep/24 Map and array parameter types kep/25 Template function toYaml kep/26 Parameter value files kind/enhancement
Milestone

Comments

@akirillov
Copy link
Member

What would you like to be added:
The possibility to configure operator deployment parameters such as nodeSelector, podAnnotations, and resources.

Why is this needed:
Currently, there's no structured way to provide the requested configuration. While it is possible to develop a workaround for resources by explicitly exposing all the required fields - there's no way to provide either a key-value collection for podAnnotations and nodeSelectors or a complex parameter in a YAML format for such a property as podAffinity.

In Helm, this problem is solved by using values files and a custom toYaml templating function which allows specification of any of these parameters in a valid YAML syntax in the file.

Examples:

@kensipe kensipe added this to the 0.11.0 milestone Dec 30, 2019
@kensipe
Copy link
Member

kensipe commented Dec 30, 2019

Need for KEP which likely includes details for #988

@porridge
Copy link
Member

porridge commented Mar 11, 2020

Status update:

  1. ability to create parameters of type map - is in v0.11.0. You can use this test operator as an example and there is a docs PR
  2. ability to dump a parameter value as YAML inside a template - is also in v0.11.0 and documentation for it is in the canonical place now. Basically it's to be used identically like the function with the same name in Helm.
  3. ability to conveniently pass complex parameter values into kubectl kudo - will be in the v0.12.0 release, its documentation will be merged right after the release. In v0.10.0 however you should be able to still pass them in JSON format (which is a subset of YAML) on the --parameter flag as explained in How could I use a struct as a parameter ? #951 (comment).

@porridge porridge added kep/24 Map and array parameter types kep/25 Template function toYaml kep/26 Parameter value files and removed needs-kep labels Mar 11, 2020
@porridge
Copy link
Member

All three KEPs are now implemented and released or pending release, as explained in the status update above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kep/24 Map and array parameter types kep/25 Template function toYaml kep/26 Parameter value files kind/enhancement
Projects
None yet
Development

No branches or pull requests

3 participants