chore: add target to update golden-files for individual tests #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zain Malik <zmalikshxil@gmail.com>
ANeumann82
approved these changes
Feb 28, 2020
Indeed! I like this! |
Signed-off-by: Zain Malik <zmalikshxil@gmail.com> Co-Authored-By: Marcin Owsiany <mowsiany@D2iQ.com>
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
* chore: add make target to update golden-files for individual tests * Apply suggestions from code review Signed-off-by: Zain Malik <zmalikshxil@gmail.com> Co-Authored-By: Marcin Owsiany <mowsiany@D2iQ.com> Co-authored-by: Marcin Owsiany <marcin@owsiany.pl> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zain Malik zmalikshxil@gmail.com
What this PR does / why we need it:
Updating the golden files for tests wasn't documented and for first time contributors to those it can be hard to discover how to do it.
This PR adds a Make target to update golden files, and requires the name of individual test to update only one by one. This is to address concerns to avoid doing a massive update in golden files by error
examples: