Update golden files the easy way #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
|
I'm ok with that. I review my changes anyway before committing, so this works for me |
ANeumann82
approved these changes
Mar 4, 2020
|
good eye @zmalik thanks for pointing that out... on it |
Signed-off-by: Ken Sipe <kensipe@gmail.com>
zmalik
approved these changes
Mar 5, 2020
runyontr
pushed a commit
that referenced
this pull request
Mar 11, 2020
Signed-off-by: Ken Sipe <kensipe@gmail.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to #1369
There seemed to be a concern of "massive updates" which doesn't make sense to me.
The requirement to know all tests and manually type each in or copy and paste them is an unnecessary burden on the developer IMO. Updating the entire project will update all affected files. If there is a file that was updated that is a surprise to the developer they should investigate before pushing a PR. Additionally any file that changed that was NOT updated would have failed any tests anyway. Lets make it easier on us please.
Signed-off-by: Ken Sipe kensipe@gmail.com