Moving to KUTTL #1435
Merged
Moving to KUTTL #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
requested review from
gerred,
zmalik,
ANeumann82,
zen-dog and
jbarrick-mesosphere
|
looks like e2e needs to be looked at |
ANeumann82
reviewed
Mar 24, 2020
| @@ -30,7 +32,7 @@ func TestEnhancerApply_embeddedMetadataStatefulSet(t *testing.T) { | |||
|
|
|||
| e := &DefaultEnhancer{ | |||
| Scheme: utils.Scheme(), | |||
| Discovery: utils.FakeDiscoveryClient(), | |||
| Discovery: fake.CachedDiscoveryClient(), | |||
ANeumann82
approved these changes
Mar 24, 2020
|
I agree with using CachedDiscoveryInterface here and not in kuttl. |
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent work around get API resources was using testing code. That needed to be refactored.
If you feel strongly that FakeDiscoveryInterfaceClient should be moved to KUTTL please make it known.