-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving to KUTTL #1435
Moving to KUTTL #1435
Conversation
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
looks like e2e needs to be looked at |
@@ -30,7 +32,7 @@ func TestEnhancerApply_embeddedMetadataStatefulSet(t *testing.T) { | |||
|
|||
e := &DefaultEnhancer{ | |||
Scheme: utils.Scheme(), | |||
Discovery: utils.FakeDiscoveryClient(), | |||
Discovery: fake.CachedDiscoveryClient(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the failing tests, this looks good. As already mentioned, I don't think kuttl needs the CachedDiscoveryInterface.
I agree with using CachedDiscoveryInterface here and not in kuttl. |
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Recent work around get API resources was using testing code. That needed to be refactored.
If you feel strongly that FakeDiscoveryInterfaceClient should be moved to KUTTL please make it known.