Keep plan name in instance aggregatedStatus when plan is terminal #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
we were resetting `Status.AggregatedStatus.ActivePlanName` field when the plan was terminal. This lead to this field looking like this:
```
Status:
Aggregated Status:
Status: COMPLETE
```
The idea of the field is to keep information of the last/current plan including plan name and status.
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
zen-dog
requested review from
alenkacz,
gerred,
kensipe and
nfnt
as code owners
ANeumann82
approved these changes
Mar 31, 2020
zen-dog
changed the title
nfnt
reviewed
Apr 1, 2020
I agree with a confusing name, however, introducing a breaking change just to rename a field is unnecessary. Also, I'm planning to remove the |
kensipe
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
we were resetting
Status.AggregatedStatus.ActivePlanNamefield when the plan was terminal. This lead to this field looking like this:The idea of the field is to keep information about the last/current plan including plan name and status.
Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com