Skip to content

Commit

Permalink
Keep plan name in instance aggregated status when plan is terminal (#…
Browse files Browse the repository at this point in the history
…1451)

Summary:
we were resetting `Status.AggregatedStatus.ActivePlanName` field when the plan was terminal. This lead to this field looking like this:
```
Status:
  Aggregated Status:
    Status:  COMPLETE
```
The idea of the field is to keep information of the last/current plan including plan name and status.

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
  • Loading branch information
Aleksey Dukhovniy authored Apr 2, 2020
1 parent 08355d9 commit 82511c3
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions pkg/apis/kudo/v1beta1/instance_types_helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,6 @@ func (i *Instance) UpdateInstanceStatus(planStatus *PlanStatus, updatedTimestamp
planStatus.LastUpdatedTimestamp = updatedTimestamp
i.Status.PlanStatus[k] = *planStatus
i.Status.AggregatedStatus.Status = planStatus.Status
if planStatus.Status.IsTerminal() {
i.Status.AggregatedStatus.ActivePlanName = ""
}
}
}
}
Expand Down

0 comments on commit 82511c3

Please sign in to comment.