Package Verify Support for Template Range #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com> params for range nodes work Signed-off-by: Ken Sipe <kensipe@gmail.com> adding support for template range Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
force-pushed
the
ken/range-verify
branch
from
0ae6575
to
bb4b9a9
Compare
gerred
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing this I was hesitate to call this a bug as recorded... since it is documented as
// no support for Range, Template or TextNodes:) We didn't document that outside of code and it is worth having this feature (and needed for our kafka operator). Thanks @zmalik for being awesome and reporting this.kudo package verifynow supports range. Tests provided.Fixes #1432