Docker publishing updates #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
requested review from
alenkacz,
gerred,
nfnt and
zen-dog
as code owners
nfnt
approved these changes
Apr 17, 2020
porridge
reviewed
Apr 20, 2020
| binaries: | ||
| - manager | ||
| image_templates: | ||
| - "kudobuilder/controller:latest" |
There was a problem hiding this comment.
Is there anything that uses :latest? (AFAICT even if someone manually specifies --version=latest it won't work because we prefix the value with letter v:
kudo/pkg/kudoctl/kudoinit/options.go
Line 42 in 5ca644e
Why not just get rid of the :latest altogether?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better solution to #1468
The solution here is to always push the release tag (even if it is an RC release) but to only bump the
:latesttag for full releases.Signed-off-by: Ken Sipe kensipe@gmail.com
Fixes #1466