Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always Docker Push on Release Including RC #1468

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Always Docker Push on Release Including RC #1468

merged 1 commit into from
Apr 16, 2020

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Apr 15, 2020

skip_push: auto means that goreleaser will not push to docker for rc releases and will push for full releases. Our process expects RC images.

details from docs

    # Skips the docker push. Could be useful if you also do draft releases.
    # If set to auto, the release will not be pushed to the docker repository
    # in case there is an indicator for prerelease in the tag e.g. v1.0.0-rc1
    # Defaults to false.
    skip_push: false

The default is false, which is what we want...

Signed-off-by: Ken Sipe kensipe@gmail.com

Fixes #1466

@kensipe
Always Docker Push on Release Including RC
b3bfd2a 
Signed-off-by: Ken Sipe <kensipe@gmail.com>
zen-dog
zen-dog approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@kensipe kensipe merged commit 2476776 into master Apr 16, 2020
@kensipe kensipe deleted the ken/always-docker-push branch April 16, 2020 12:49
@kensipe kensipe mentioned this pull request Apr 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zen-dog zen-dog zen-dog approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz alenkacz is a code owner

@gerred gerred Awaiting requested review from gerred gerred is a code owner

@nfnt nfnt Awaiting requested review from nfnt nfnt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad experience installing KUDO
2 participants
@kensipe @zen-dog