Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial tests for CICD captured by make test #153

Merged
merged 15 commits into from
Mar 14, 2019
Merged

Conversation

runyontr
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  1. Add tooling into codebase to be able to perform the following checks:
    a. go fmt -
    b. go vet -
    c. golint - Standarizes the format of files
    d. goimports - Standardize the imports for packages

  2. Get codebase into a state that it passes all of these checks

make test
go generate ./pkg/... ./cmd/...
go install github.com/kudobuilder/kudo/vendor/golang.org/x/tools/cmd/goimports
go install github.com/kudobuilder/kudo/vendor/golang.org/x/lint/golint
go fmt ./pkg/... ./cmd/...
go vet ./pkg/... ./cmd/...
golint ./pkg/... ./cmd/...
goimports -w ./pkg/ ./cmd/
go run vendor/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go all
Breaking recursion for type github.com/kudobuilder/kudo/pkg/apis/kudo/v1alpha1.FrameworkVersionCRD manifests generated under '/Users/tom/go/src/github.com/kudobuilder/kudo/config/crds'
RBAC manifests generated under '/Users/tom/go/src/github.com/kudobuilder/kudo/config/rbac'
go test ./pkg/... ./cmd/... -coverprofile cover.out
?   	github.com/kudobuilder/kudo/pkg/apis	[no test files]
?   	github.com/kudobuilder/kudo/pkg/apis/kudo	[no test files]
ok  	github.com/kudobuilder/kudo/pkg/apis/kudo/v1alpha1	11.525s	coverage: 8.3% of statements
?   	github.com/kudobuilder/kudo/pkg/controller	[no test files]
ok  	github.com/kudobuilder/kudo/pkg/controller/framework	12.261s	coverage: 0.0% of statements
ok  	github.com/kudobuilder/kudo/pkg/controller/frameworkversion	10.929s	coverage: 0.0% of statements
ok  	github.com/kudobuilder/kudo/pkg/controller/instance	11.521s	coverage: 0.0% of statements
ok  	github.com/kudobuilder/kudo/pkg/controller/planexecution	11.561s	coverage: 0.0% of statements
?   	github.com/kudobuilder/kudo/pkg/util/health	[no test files]
?   	github.com/kudobuilder/kudo/pkg/util/template	[no test files]
?   	github.com/kudobuilder/kudo/pkg/webhook	[no test files]
?   	github.com/kudobuilder/kudo/cmd/kudoctl	[no test files]
?   	github.com/kudobuilder/kudo/cmd/kudoctl/cmd	[no test files]
?   	github.com/kudobuilder/kudo/cmd/kudoctl/cmd/list	[no test files]
?   	github.com/kudobuilder/kudo/cmd/kudoctl/cmd/plan	[no test files]
?   	github.com/kudobuilder/kudo/cmd/manager	[no test files]

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Make sure to pull down and test the make command to ensure that it's getting installed correctly and it was just pre-installed on my system.

Does this PR introduce a user-facing change?:

CICD!

Makefile Outdated Show resolved Hide resolved
Gopkg.toml Show resolved Hide resolved
@gerred gerred merged commit a07dc7c into master Mar 14, 2019
@gerred gerred deleted the go-syntax-checks branch March 14, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants