Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify instance controller reconciliation #1551

Merged
merged 7 commits into from
Jun 8, 2020
Merged

Simplify instance controller reconciliation #1551

merged 7 commits into from
Jun 8, 2020

Commits on Jun 4, 2020

  1. Simplify instance controller reconciliation 

    Summary:
current instance controller reconciliation logic with regard to detecting currently active plan can be much simpler now that we have IAW (instance admission webhook) controlling the scheduled plan.

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    b217482 View commit details
    Browse the repository at this point in the history

  2. making linter happy 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    09583c9 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2020

  1. review feedback with logging and naming improvements 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    10fdf9a View commit details
    Browse the repository at this point in the history

  2. fixed some typos 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    649fec9 View commit details
    Browse the repository at this point in the history

  3. initializing plan status only when the plan is new or upgrade 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    cd69d8d View commit details
    Browse the repository at this point in the history

  4. simplified ensurePlanStatusInitialized method and added a test for it 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    b032fbb View commit details
    Browse the repository at this point in the history

  5. making linter happy 

    Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
    @zen-dog
    zen-dog committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    a3e6a98 View commit details
    Browse the repository at this point in the history