Reconcile parent instances when a child instance is done #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: after updating the [flink-demo](kudobuilder/operators#279) to use dependencies a few fixes were needed: - instance controller now properly reconciles (parent) instances owning child instances - `InClusterResolver` ignores operators `appVersion` if it wasn't set - child instance names are generated differently: - if the `instanceName` was set, it is taken without modifications - otherwise, `parentInstance-childOperator` is taken e.g. `kafka-zookeeper`. in this case we also use `-` instead of `.` separator since instance names are often used as service names (DNS-1035 label) which only allow alphanumeric characters or `-` in them. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
kensipe
approved these changes
Jun 25, 2020
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
…e operator was resolved Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
zen-dog
commented
Jun 25, 2020
| @@ -25,11 +25,6 @@ func (r InClusterResolver) Resolve(name string, appVersion string, operatorVersi | |||
| return nil, fmt.Errorf("failed to resolve operator version %s/%s:%s", r.ns, ovn, appVersion) | |||
| } | |||
|
|
|||
| // sanity check, as there is an explicit 1:1 relationship between an operator and app version | |||
There was a problem hiding this comment.
On the second thought: this sanity check didn't make any sense
zen-dog
commented
Jun 25, 2020
| @@ -143,6 +143,7 @@ func updateKudoOperatorTaskPackageNames( | |||
| for _, dependency := range dependencies { | |||
| if tasks[i].Spec.KudoOperatorTaskSpec.Package == dependency.PackageName { | |||
| tasks[i].Spec.KudoOperatorTaskSpec.Package = dependency.Operator.Name | |||
| tasks[i].Spec.KudoOperatorTaskSpec.OperatorVersion = dependency.OperatorVersion.Spec.Version | |||
There was a problem hiding this comment.
@nfnt this is for cases when the user didn't specify the KudoOperatorTaskSpec.OperatorVersion and it was resolved to the latest one. the field has to be populated by the CLI
There was a problem hiding this comment.
Good catch! I wasn't aware of the implications of this field being optional. In this case, the same must be done for KudoOperatorTaskSpec.AppVersion. And the function name and description needs to be updated as well, how about simply updateKudoOperatorTask?
There was a problem hiding this comment.
Agree about the method name but the AppVersion is not needed on the server-side so 🤷
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
after updating the flink-demo to use dependencies a few fixes were needed:
InClusterResolverignores operatorsappVersionif it wasn't setinstanceNamewas set, it is taken without modificationsparentInstance-childOperatoris taken e.g.kafka-zookeeper. in this case, we also use-instead of.separator since instance names are often used as service names (DNS-1035 label) which only allow alphanumeric characters or-in them.Signed-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com