Update flink-demo to use operator dependencies #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - using `KudoOperator` task to include Zookeeper, Kafka and Flink dependencies directly instead of pre-installing them manually (and activate using `Instance` resources) - the corresponding parameters are in the params files e.g. `templates/kafka-params.yaml` - README is updated to reflect the latest changes - demo relies on not yet releases kudoctl and manager Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
zen-dog
added a commit
to kudobuilder/kudo
that referenced
this pull request
Jun 25, 2020
Summary: after updating the [flink-demo](kudobuilder/operators#279) to use dependencies a few fixes were needed: - instance controller now properly reconciles (parent) instances owning child instances - `InClusterResolver` ignores operators `appVersion` if it wasn't set - child instance names are generated differently: - if the `instanceName` was set, it is taken without modifications - otherwise, `parentInstance-childOperator` is taken e.g. `kafka-zookeeper`. in this case we also use `-` instead of `.` separator since instance names are often used as service names (DNS-1035 label) which only allow alphanumeric characters or `-` in them. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
zen-dog
pushed a commit
to kudobuilder/kudo
that referenced
this pull request
Jun 29, 2020
Summary: after updating the [flink-demo](kudobuilder/operators#279) to use dependencies a few fixes were needed: - instance controller now properly reconciles (parent) instances owning child instances - `InClusterResolver` ignores operators `appVersion` if it wasn't set - child instance names are generated differently: - if the `instanceName` was set, it is taken without modifications - otherwise, `parentInstance-childOperator` is taken e.g. `kafka-zookeeper`. in this case we also use `-` instead of `.` separator since instance names are often used as service names (DNS-1035 label) which only allow alphanumeric characters or `-` in them. Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
kensipe
requested changes
Jul 1, 2020
There was a problem hiding this comment.
My tests needed to deviate because things are not released... details below (but I believe this should work)... the end result issue:
kubectl kudo plan status --instance flink-demo
Plan(s) for "flink-demo" in namespace "default":
.
└── flink-demo (Operator-Version: "flink-demo-0.1.5" Active-Plan: "deploy")
└── Plan deploy (serial strategy) [FATAL_ERROR], last updated 2020-07-01 08:37:22
├── Phase dependencies (serial strategy) [FATAL_ERROR]
│ ├── Step zookeeper [FATAL_ERROR] (default/flink-demo fatal error: failed to build task deploy.dependencies.zookeeper.zookeeper: task validation error: kudo operator task 'zookeeper' has an empty operator name)
Deviations:
- running local manager with
KUDO_CERT_DIR=./test/cert/ make run - Installing from the local files system:
go run cmd/kubectl-kudo/main.go install ../operators/repository/flink/docs/demo/financial-fraud/demo-operator/ --instance flink-demo
Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
|
and tested it with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
KudoOperatortask to include Zookeeper, Kafka and Flink dependencies directly instead of pre-installing them manually (and activate usingInstanceresources)templates/kafka-params.yamlSigned-off-by: Aleksey Dukhovniy alex.dukhovniy@googlemail.com