Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark instance as required parameter for diagnostics #1598

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Mark instance as required parameter for diagnostics #1598

merged 1 commit into from
Jul 16, 2020

Conversation

alenkacz
Copy link
Contributor

What this PR does / why we need it:
Currently it is not required and yields the following error:

./bin/kubectl-kudo diagnostics collect
Collect Logs for 1 pods
Error: failed to get instance default/: resource name may not be empty

@alenkacz
Mark instance as required parameter for diagnostics
6354281 
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
ANeumann82
ANeumann82 approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@ANeumann82 ANeumann82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

zen-dog
zen-dog approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🚢

@alenkacz alenkacz merged commit 594ae5d into main Jul 16, 2020
@alenkacz alenkacz deleted the av/diag-instance-required branch July 16, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ANeumann82 ANeumann82 ANeumann82 approved these changes

@nfnt nfnt nfnt approved these changes

@zen-dog zen-dog zen-dog approved these changes

@gerred gerred Awaiting requested review from gerred

@kensipe kensipe Awaiting requested review from kensipe kensipe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alenkacz @ANeumann82 @nfnt @zen-dog