Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand kudo get command #1658

Merged
merged 6 commits into from
Sep 3, 2020
Merged

Expand kudo get command #1658

merged 6 commits into from
Sep 3, 2020

Conversation

ANeumann82
Copy link
Member

@ANeumann82 ANeumann82 commented Aug 24, 2020

What this PR does / why we need it:
Extends the kudo get command. It now supports

  • Get "instances", "operators", "operatorversions" and "all".
  • --output yaml or --output json

Examples:

kudo get all

List of current installed operators including versions and instances in namespace "default":
.
└── some-operator
    └── some-operator-0.1.0
        └── test

kudo get operators --output yaml

---
apiVersion: kudo.dev/v1beta1
kind: Operator
metadata:
  creationTimestamp: null
  name: some-operator
  namespace: default
spec:
  description: A fancy Operator
  kudoVersion: 0.16.0
status: {}

...

Fixes #556, #331

Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. I have only minor comments and nitpicks. You likely need to rebase, it looks like some parts of #1652 are mistakenly part of this PR, e.g. all the changes to test/upgrade/upgrade-to-current.

pkg/kudoctl/cmd/get/get.go Outdated Show resolved Hide resolved
pkg/kudoctl/cmd/get/get.go Outdated Show resolved Hide resolved
pkg/kudoctl/cmd/get/get.go Outdated Show resolved Hide resolved
pkg/kudoctl/cmd/get/get.go Show resolved Hide resolved
pkg/kudoctl/cmd/get/get.go Outdated Show resolved Hide resolved
pkg/kudoctl/cmd/get/get.go Show resolved Hide resolved
pkg/kudoctl/cmd/get/get.go Outdated Show resolved Hide resolved
# Conflicts:
#	.gitignore
#	test/upgrade/upgrade-to-current/01-install-operator.yaml
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ANeumann82 ANeumann82 merged commit ecaf66e into main Sep 3, 2020
@ANeumann82 ANeumann82 deleted the an/expand-get-command branch September 3, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need Output Flag for CLI Get Instances
2 participants