Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golangci-lint to, use the new version subcommand. #1687

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Bump golangci-lint to, use the new version subcommand. #1687

merged 2 commits into from
Sep 18, 2020

Conversation

porridge
Copy link
Member

What this PR does / why we need it:

The new release has a version --short subcommand that makes it possible to
get rid of the somewhat hacky parsing.

@porridge
Bump golangci-lint to, use the new version subcommand.
3458e94 
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
kensipe
kensipe approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how great is that! :)

thanks @porridge !
/lgtm

nfnt
nfnt approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@nfnt
Copy link
Member

nfnt commented Sep 18, 2020

Please also change the version of golangci-lint in hack/install-golangcilint.sh. There's a bug in the tooling: The install script doesn't honor the version set in the Makefile. I.e., if versions differ in these files, make lint will check for the version specified in the Makefile but download the version specified in the install script. This will be fixed with #1688. But until then, versions in Makefile and install script have to match.

@porridge
address feedback - specify version where it should be
6e86c5b 
Signed-off-by: Marcin Owsiany <mowsiany@D2iQ.com>
@porridge
Copy link
Member Author

Good catch @nfnt! Pushed.

@nfnt nfnt merged commit b4b17b7 into main Sep 18, 2020
@nfnt nfnt deleted the porridge/bump-linter branch September 18, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kensipe kensipe kensipe approved these changes

@nfnt nfnt nfnt approved these changes

@alenkacz alenkacz Awaiting requested review from alenkacz alenkacz is a code owner

@gerred gerred Awaiting requested review from gerred

@zen-dog zen-dog Awaiting requested review from zen-dog zen-dog is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@porridge @nfnt @kensipe