Use a version parameter in the linter install script #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid specifying the version of 'golangci-lint' in multiple places, it is now a parameter in the 'install-golangcilint.sh' script. With this change, the version of 'golangci-lint' is only declared in the Makefile. Signed-off-by: Jan Schlicht <jan@d2iq.com>
nfnt
requested review from
alenkacz,
gerred,
kensipe and
zen-dog
as code owners
Signed-off-by: Jan Schlicht <jan@d2iq.com>
porridge
approved these changes
Sep 18, 2020
added 2 commits
September 18, 2020 16:25
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To avoid specifying the version of
golangci-lintin multiple places, it is now a parameter in theinstall-golangcilint.shscript. With this change, the version ofgolangci-lintis only declared in the Makefile.