Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for cassandra parameter regression #1744

Merged
merged 3 commits into from Nov 24, 2020
Merged

Conversation

alenkacz
Copy link
Contributor

Signed-off-by: Alena Varkockova varkockova.a@gmail.com

What this PR does / why we need it:
Cassandra 1.0.2 marked a parameter as immutable, that also has a default value. That caused a regression being fixed in #1738

This is a test covering that regression. We already have a test for immutable params but they are providing a param value on install and that means the bug does not get triggered.

Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
@alenkacz
Copy link
Contributor Author

this is expected to be failing until that other PR gets merged

Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Signed-off-by: Alena Varkockova <alenavarkockova@10.0.0.15>
@alenkacz alenkacz merged commit 9f86f0f into main Nov 24, 2020
@alenkacz alenkacz deleted the av/cass-regression-test branch November 24, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants