Integration test command should run all integration tests #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
kensipe
reviewed
Nov 16, 2020
|
|
||
| echo "Running KUTTL integration tests" | ||
|
|
||
| ./hack/run-kuttl-tests.sh |
There was a problem hiding this comment.
It would be better to have this called from the script location and not assume where it is called from... but non-blocking
kensipe
approved these changes
Nov 16, 2020
|
I prefer to think of "integration" as Go integration tests... and kuttl as mainly e2e tests. this blurs that. |
|
@kensipe yeah I see how that can be confusing but these tests are really integration tests (and yes, we have kuttl e2e tests as well) I would actually say that for kuttl integration and e2e are on the same level, it just depends whether you use |
Signed-off-by: Alena Varkockova <alenavarkockova@10.0.0.15>
ANeumann82
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We agreed on this with Andreas here https://kubernetes.slack.com/archives/CG3HTFCMV/p1603361976115700?thread_ts=1603360951.111500&cid=CG3HTFCMV
Context: There was a PR that has splitted KUTTL tests out of integration-test command. The reason was to be easily able to run just a single test. But as a result, command that's named
integration-testnow runs only a subset of integration tests and I think that's very confusing. The solution is to keep kuttl test separate for whoever needs it but have all integration tests again under one makefile command.