Fix added steps in upgraded operator #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
requested review from
alenkacz,
gerred,
kensipe and
zen-dog
as code owners
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
alenkacz
approved these changes
Jan 19, 2021
| if stepStatus.Name == name { | ||
| return &stepStatus | ||
| return &s.Steps[i] |
There was a problem hiding this comment.
Yeaaahh..... Fun with go references 🤦
ANeumann82
changed the title
ANeumann82
added a commit
that referenced
this pull request
Jan 20, 2021
* Add another scenario to e2e test * Initialise Status in the same order as the plan * Fix getters to return correct reference Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andreas Neumann aneumann@mesosphere.com
What this PR does / why we need it:
Fixes #1754