Updated FrameworkSpec with metadata from KEP009 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guenter
reviewed
May 30, 2019
| properties: | ||
| description: | ||
| type: string | ||
| kubeVersion: |
There was a problem hiding this comment.
IMO this should be kubernetesVersion to avoid any confusion as pointed out here: #263 (comment)
There was a problem hiding this comment.
Agreed. KEP 9 will be adjusted (thanks @hectorj2f). The original motivation for kubeVersion was consistency with Helm's Chart.yaml usage of it.
fabianbaier
reviewed
May 30, 2019
| @@ -21,10 +21,16 @@ import ( | |||
|
|
|||
| // FrameworkSpec defines the desired state of Framework | |||
| type FrameworkSpec struct { | |||
There was a problem hiding this comment.
Should we do some of the fields or all maybe with ,omitempty tags?
| KudoVersion string `json:"kudoVersion"` | ||
| KubernetesVersion string `json:"kubeVersion"` | ||
| Maintainers []Maintainer `json:"maintainers"` | ||
| URL string `json:"url"` |
There was a problem hiding this comment.
What about name and version?
There was a problem hiding this comment.
Those are captured in the metadata.name field and the FrameworkVersion objects
hectorj2f
approved these changes
Jun 4, 2019
6 tasks
gerred
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
/kind enhancement
What this PR does / why we need it:
Update the framework spec to include metadata defined in here: https://github.com/kudobuilder/kudo/blob/master/keps/0009-operator-toolkit.md#frameworkyaml
Which issue(s) this PR fixes:
Part of Issue #269
Special notes for your reviewer:
Does this PR introduce a user-facing change?: