-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated FrameworkSpec with metadata from KEP009 #277
Conversation
properties: | ||
description: | ||
type: string | ||
kubeVersion: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this should be kubernetesVersion
to avoid any confusion as pointed out here: #263 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. KEP 9 will be adjusted (thanks @hectorj2f). The original motivation for kubeVersion was consistency with Helm's Chart.yaml
usage of it.
@@ -21,10 +21,16 @@ import ( | |||
|
|||
// FrameworkSpec defines the desired state of Framework | |||
type FrameworkSpec struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we do some of the fields or all maybe with ,omitempty
tags?
KudoVersion string `json:"kudoVersion"` | ||
KubernetesVersion string `json:"kubeVersion"` | ||
Maintainers []Maintainer `json:"maintainers"` | ||
URL string `json:"url"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about name
and version
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are captured in the metadata.name
field and the FrameworkVersion
objects
What type of PR is this?
/kind api-change
/kind enhancement
What this PR does / why we need it:
Update the framework spec to include metadata defined in here: https://github.com/kudobuilder/kudo/blob/master/keps/0009-operator-toolkit.md#frameworkyaml
Which issue(s) this PR fixes:
Part of Issue #269
Special notes for your reviewer:
Does this PR introduce a user-facing change?: