Remove possibility to install multiple packages #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
commented
Jul 1, 2019
pkg/kudoctl/cmd/install/install.go
Outdated
| kc, err := kudo.NewClient(options.Namespace, options.KubeConfigPath) | ||
| if err != nil { | ||
| return errors.Wrap(err, "creating kudo client") | ||
| if len(args) != 1 { |
There was a problem hiding this comment.
this is the main change
fabianbaier
requested changes
Jul 1, 2019
|
@fabianbaier thanks, great feedback :) fixed |
|
@fabianbaier are you good here? I want this to land before I get to carried away with some refactor that includes install from url. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
There are two main things in this PR:
-- I don't see much use cases for doing that vs running two
kudo installcommands-- it was not documented anywhere anyway so I think we can just remove it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: