tests for bundle finder and http client

pkg/kudoctl/bundle/finder/bundle_finder_test.go

@@ -0,0 +1,46 @@
+package finder
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestManager_GetBundle(t *testing.T) {
+	f := &Manager{
+		local: NewLocal(),
+		uri:   nil,
+	}
+	b, err := f.GetBundle("../testdata/zk", "")
+	if err != nil {
+		t.Errorf("Manager.GetBundle() error = %v", err)
+		return
+	}
+
+	crd, err := b.GetCRDs()
+	if err != nil {
+		t.Errorf("bundle.GetCRDs error = %v", err)
+	}
+	assert.EqualValues(t, "zookeeper", crd.Operator.Name)
+}
+
+func TestLocalFinder_GetBundle(t *testing.T) {
+	f := NewLocal()
+	b, err := f.GetBundle("../testdata/zk", "")
+	if err != nil {
+		t.Errorf("Manager.GetBundle() error = %v", err)
+		return
+	}
+
+	crd, err := b.GetCRDs()
+	if err != nil {
+		t.Errorf("bundle.GetCRDs error = %v", err)
+	}
+	assert.EqualValues(t, "zookeeper", crd.Operator.Name)
+}
+
+func TestLocalFinder_Failure(t *testing.T) {
+	f := NewLocal()
+	_, err := f.GetBundle("../testdata/zk-bad", "")
+	assert.Errorf(t, err, "should have errored on bad folder name")
+}

pkg/kudoctl/http/http_client_test.go

@@ -0,0 +1,26 @@
+package http
+
+import (
+	"testing"
+)
+
+func TestIsValidURL(t *testing.T) {
+
+	tests := []struct {
+		name string
+		uri  string
+		want bool
+	}{
+		{name: "string", uri: "foo", want: false},
+		{name: "http", uri: "http://kudo.dev", want: true},
+		{name: "https", uri: "https://kudo.dev", want: true},
+		{name: "no http prefix", uri: "kudo.dev", want: false},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := IsValidURL(tt.uri); got != tt.want {
+				t.Errorf("IsValidURL() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}