Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile build info should be identical to goreleaser build info #579

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Jul 15, 2019

What type of PR is this?
/component kudoctl
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #577

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@kensipe kensipe requested a review from gerred as a code owner July 15, 2019 14:44
@kensipe kensipe requested review from alenkacz and zmalik July 15, 2019 14:44
@yankcrime yankcrime added component/cli kubectl kudo a.k.a. kudoctl kind/bug labels Jul 15, 2019
Copy link
Member

@fabianbaier fabianbaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kensipe kensipe merged commit 10d897e into master Jul 15, 2019
@alenkacz alenkacz deleted the ken/version-goreleaser-alignment branch October 30, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last Release of CLI 0.3.2 had a change in reported version
4 participants