Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-Port: Makefile build info should be identical to goreleaser build info (#579) #580

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Jul 15, 2019

What type of PR is this?
/component kudoctl
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@kensipe kensipe requested a review from fabianbaier July 15, 2019 17:41
@kensipe kensipe requested a review from gerred as a code owner July 15, 2019 17:41
@kensipe kensipe added this to In progress in KUDO via automation Jul 15, 2019
Copy link
Member

@fabianbaier fabianbaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Great that we follow this practice now for bugs and cross reference as well #579

KUDO automation moved this from In progress to Reviewer approved Jul 15, 2019
@kensipe kensipe merged commit c7b29e7 into releases/0.3 Jul 15, 2019
KUDO automation moved this from Reviewer approved to Done Jul 15, 2019
@alenkacz alenkacz deleted the ken/make-version-bp branch October 30, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
KUDO
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants