Repo Index #730
Repo Index #730
Conversation
Adding package cmd to cli docs
testing with in mem fs code clean up missed afero call for fromFolder
Co-Authored-By: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
|
I looked into rebasing... but it was too painful. which stems for this PR being built of a PR which took an significant amount of time (hence a significant deviation from master). |
|
Hey @kensipe, I will review this by Wednesday evening. Currently traveling. |
pkg/kudoctl/cmd/repo_index.go
Outdated
| } | ||
|
|
||
| i.WriteFile(fs, target) | ||
| ri.out.Write([]byte(fmt.Sprintf("index %v created.\n", target))) |
There was a problem hiding this comment.
We should be moving more toward a pattern like this so that we can replace the Reader for testing (fmt.Printf forces you into os.Stdout).
As an aside, I DO prefer:
https://godoc.org/fmt#Fprintf which takes a writer as the first argument and does some work around caching buffers for printers. It does the exact same thing, just more robustly.
Co-Authored-By: Gastón Kleiman <gaston.kleiman@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gerred, kensipe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kensipe
dismissed
gkleiman’s stale review
multiple requests for re-review not responded to. The request for changes was addressed.
What type of PR is this?
/component kudoctl
/kind feature
What this PR does / why we need it:
This feature adds the ability to create an index file for a folder of operator tarballs.
Which issue(s) this PR fixes:
Fixes #622
Special notes for your reviewer:
Does this PR introduce a user-facing change?: