Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect test metadata in integration tests #773

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Collect test metadata in integration tests #773

merged 3 commits into from
Sep 10, 2019

Conversation

nfnt
Copy link
Member

@nfnt nfnt commented Sep 10, 2019

What type of PR is this?
/kind enhancement

What this PR does / why we need it:
The 'go-junit-report' project is used to convert go test output to a JUnit XML report. CircleCI is instructed to store these test results.

Which issue(s) this PR fixes:

Fixes #703

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Individual test results

The 'go-junit-report' project is used to convert 'go test' output to a JUnit XML report. CircleCI is instructed to store these test results.
@nfnt nfnt requested a review from gerred as a code owner September 10, 2019 11:10
@kudo-ci
Copy link

kudo-ci commented Sep 10, 2019

Welcome @nfnt! It looks like this is your first PR to kudobuilder/kudo 🎉

@kudo-ci
Copy link

kudo-ci commented Sep 10, 2019

Hi @nfnt. Thanks for your PR.

I'm waiting for a kudobuilder member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚢

@nfnt
Copy link
Member Author

nfnt commented Sep 10, 2019

I'm testing failed test reporting in #778.

@nfnt
Copy link
Member Author

nfnt commented Sep 10, 2019

Small issue with error reporting of failed tests: Even though some tests failed, the overall result was reported as successful. Will have to fix this. This is how failed tests look in CircleCI.

Failed test cases

Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L-O-V-E this ❤️

@kudo-ci
Copy link

kudo-ci commented Sep 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alenkacz, nfnt, zen-dog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nfnt
Copy link
Member Author

nfnt commented Sep 10, 2019

Please hold with merging until I fixed the wrong reporting of failed tests.

@nfnt
Copy link
Member Author

nfnt commented Sep 10, 2019

It's working now with 7fce66b. Take a look at #778 to see how failed test cases are reported.

@kudobuilder kudobuilder deleted a comment from kudo-ci Sep 10, 2019
@nfnt nfnt self-assigned this Sep 10, 2019
@nfnt nfnt merged commit b9438a7 into kudobuilder:master Sep 10, 2019
@nfnt nfnt deleted the nfnt/circleci-test-results branch September 10, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

junit output for out tests
4 participants