Fix flake in operator-in-operator test #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
commented
Sep 11, 2019
| } else { | ||
| log.Printf("PlanExecutionController: received event from Instance %s/%s but instance of that name does not exist", a.Meta.GetNamespace(), a.Meta.GetName()) | ||
| } | ||
|
|
There was a problem hiding this comment.
the diff is really weird, but the only change is that I removed the if len(requests) == 0 and now I trigger it for inner as well as outer all the time. More the merrier, right! :D .
But I really saw that in the test logs, that we missed triggering reconciliation for the inner instance and because of that the plan never finished.
kensipe
approved these changes
Sep 11, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alenkacz, kensipe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kensipe
pushed a commit
that referenced
this pull request
Sep 12, 2019
kensipe
added a commit
that referenced
this pull request
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flakes I have seen were all in operator-in-operator test. The reason for them was that in this PR 47e7da7 I have moved code to create PE relation to instance controller, but that means that we need to make sure that reconciliation is triggered not only after PE is created but also after PE is linked to instance. That was not happening for the instance in instance example because I was triggering reconcile only for the outer instance.
Fixes #766