Add API Extensions v1beta1 to scheme #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
approved these changes
Oct 8, 2019
alenkacz
pushed a commit
that referenced
this pull request
Oct 8, 2019
alenkacz
added a commit
that referenced
this pull request
Oct 8, 2019
samvantran
reviewed
Oct 8, 2019
| @@ -24,6 +24,7 @@ import ( | |||
| "github.com/kudobuilder/kudo/pkg/controller/operator" | |||
| "github.com/kudobuilder/kudo/pkg/controller/operatorversion" | |||
| "github.com/kudobuilder/kudo/pkg/version" | |||
| apiextenstionsv1beta1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1" | |||
There was a problem hiding this comment.
phew at least it's consistent! :) will get that fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables operator developers to use CRDs. This scheme isn't explicitly added by core APIs. @kensipe when we go to CRDv1 we'll need to add that to the scheme as well. We won't want to remove this one because we don't necessarily mind if someone wants to manage CRD/v1beta1 CRDs via KUDO.
This is blocking someone, so I'd like to cherry pick this to 0.7.3 as well and ship it tomorrow.