Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kudo to 0.5.0, clean up testing Makefile. #62

Merged

Conversation

jbarrick-mesosphere
Copy link
Member

No description provided.

@jbarrick-mesosphere
Copy link
Member Author

/kind cleanup

@jbarrick-mesosphere
Copy link
Member Author

Could someone make sure that make test works on a Mac?

@gerred
Copy link
Member

gerred commented Aug 2, 2019

@jbarrick-mesosphere passes on MacOS Mojave. LGTM.

@kensipe
Copy link
Member

kensipe commented Aug 2, 2019

/approve

@kensipe
Copy link
Member

kensipe commented Aug 2, 2019

/lgtm

@kudo-ci
Copy link

kudo-ci commented Aug 5, 2019

New changes are detected. LGTM label has been removed.

@kudo-ci kudo-ci removed the lgtm label Aug 5, 2019
@kudo-ci
Copy link

kudo-ci commented Aug 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gerred, jbarrick-mesosphere, kensipe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gerred,jbarrick-mesosphere,kensipe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jbarrick-mesosphere jbarrick-mesosphere merged commit 5342131 into kudobuilder:master Aug 6, 2019
@jbarrick-mesosphere jbarrick-mesosphere deleted the kudo-0.5.0 branch August 6, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants