Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mainブランチにpushされた時にnetlifyへdeployされるように変更 #1109

Closed
wants to merge 1 commit into from

Conversation

ama-9
Copy link
Contributor

@ama-9 ama-9 commented Apr 2, 2024

課題・背景

ref https://smarthr.atlassian.net/browse/SD-734
デザインシステムサイトのログイン機能が動かない(ログインに失敗する)ことが頻発している。
再デプロイでログイン機能が動くようになるが、根本解決がされていない。

上記の事象の調査及び修正を行ったもの

やったこと

  • mainブランチにPRがマージされた時にDeploy to netlifyのGitHub Actionが実行されるように変更

動作確認

キャプチャ

Before After

@ama-9 ama-9 self-assigned this Apr 2, 2024
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for smarthr-design-system ready!

Name Link
🔨 Latest commit 90eedd4
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-design-system/deploys/660bb49130203e0008c44468
😎 Deploy Preview https://deploy-preview-1109--smarthr-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ama-9
Copy link
Contributor Author

ama-9 commented Apr 5, 2024

#1110 で対応するためclose

@ama-9 ama-9 closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant