Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency stylelint to ^14.16.0 #239

Merged
merged 1 commit into from Dec 8, 2022
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 14, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
stylelint (source) ^14.14.1 -> ^14.16.0 age adoption passing confidence

Release Notes

stylelint/stylelint

v14.16.0

Compare Source

v14.15.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 12pm on Monday" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the renovate label Aug 14, 2022
renovate-approve[bot]
renovate-approve bot previously approved these changes Aug 14, 2022
@netlify
Copy link

netlify bot commented Aug 14, 2022

Deploy Preview for smarthr-design-system ready!

Name Link
🔨 Latest commit ab5110e
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-design-system/deploys/638d30c37f03610008044d4a
😎 Deploy Preview https://deploy-preview-239--smarthr-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

renovate-approve[bot]
renovate-approve bot previously approved these changes Aug 14, 2022
renovate-approve[bot]
renovate-approve bot previously approved these changes Aug 14, 2022
renovate-approve[bot]
renovate-approve bot previously approved these changes Aug 14, 2022
renovate-approve[bot]
renovate-approve bot previously approved these changes Aug 14, 2022
renovate-approve[bot]
renovate-approve bot previously approved these changes Aug 14, 2022
renovate-approve[bot]
renovate-approve bot previously approved these changes Aug 14, 2022
@tomof
Copy link
Contributor

tomof commented Aug 16, 2022

v14.10.0で多くのルールが色々追加された模様。
加えて、#240 のバージョンも一緒にあげる必要がありそう。

https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#14100

image

@tomof
Copy link
Contributor

tomof commented Aug 16, 2022

stylelintをv14.10.0にすると、次のようなエラーになる。
stylelintのGitHubのissueなどを調べたが、stringifyプロパティがundefinedになるといった内容のものは見つけられなかった。すぐに解決できそうになかったのでもう少し様子見したい。

TypeError: Cannot read properties of undefined (reading 'stringify')
    at Function.stringify (/Users/tomof/project/pxgrid/smarthr-design-system/node_modules/postcss-syntax/stringify.js:8:38)
    at MapGenerator.generate (/Users/tomof/project/pxgrid/smarthr-design-system/node_modules/stylelint/node_modules/postcss/lib/map-generator.js:323:12)
    at LazyResult.stringify (/Users/tomof/project/pxgrid/smarthr-design-system/node_modules/stylelint/node_modules/postcss/lib/lazy-result.js:277:20)
    at LazyResult.runAsync (/Users/tomof/project/pxgrid/smarthr-design-system/node_modules/stylelint/node_modules/postcss/lib/lazy-result.js:443:17)
    at LazyResult.async (/Users/tomof/project/pxgrid/smarthr-design-system/node_modules/stylelint/node_modules/postcss/lib/lazy-result.js:221:30)
    at LazyResult.then (/Users/tomof/project/pxgrid/smarthr-design-system/node_modules/stylelint/node_modules/postcss/lib/lazy-result.js:206:17)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: "lint:style" exited with 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

また、前述の #239 (comment) のエラーの該当箇所をよく調べてみると全く関連性の無いエラーが出力されているので、上記の問題を解決しないとこちらの問題も解決しないのかもしれない。

@tomof
Copy link
Contributor

tomof commented Aug 16, 2022

エラーログの内容からして、postcssの👇のissueと同じ問題であると考えられる。
issueはクローズされているが、PostCSSではなくstylelintでissueを作ってくれといってクローズされていて問題は解決していない。

postcss/postcss#1767

@renovate renovate bot changed the title Update dependency stylelint to ^14.10.0 Update dependency stylelint to ^14.11.0 Aug 21, 2022
@renovate renovate bot force-pushed the renovate/stylelint-14.x branch 2 times, most recently from c68c04d to 8eecf7b Compare August 21, 2022 18:24
@renovate renovate bot changed the title Update dependency stylelint to ^14.14.1 Update dependency stylelint to ^14.14.1 - autoclosed Nov 9, 2022
@renovate renovate bot closed this Nov 9, 2022
@renovate renovate bot deleted the renovate/stylelint-14.x branch November 9, 2022 07:38
@renovate renovate bot changed the title Update dependency stylelint to ^14.14.1 - autoclosed Update dependency stylelint to ^14.14.1 Nov 13, 2022
@renovate renovate bot reopened this Nov 13, 2022
@renovate renovate bot restored the renovate/stylelint-14.x branch November 13, 2022 10:05
@renovate renovate bot changed the title Update dependency stylelint to ^14.14.1 Update dependency stylelint to ^14.15.0 Nov 13, 2022
@renovate renovate bot force-pushed the renovate/stylelint-14.x branch 6 times, most recently from f307981 to bdff122 Compare November 14, 2022 02:06
@renovate renovate bot force-pushed the renovate/stylelint-14.x branch 5 times, most recently from 89d720c to 6b215e6 Compare November 27, 2022 20:12
@renovate renovate bot changed the title Update dependency stylelint to ^14.15.0 Update dependency stylelint to ^14.16.0 Dec 4, 2022
@renovate renovate bot force-pushed the renovate/stylelint-14.x branch 4 times, most recently from c813ad6 to 09f349a Compare December 4, 2022 21:41
Copy link
Contributor

@tomof tomof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#360 にて問題が解消されたのでマージします。

@tomof tomof merged commit bcb355c into main Dec 8, 2022
@tomof tomof deleted the renovate/stylelint-14.x branch December 8, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant