fix: add necessary dependencies of hooks (#906)

kufu · Aug 4, 2020 · a14e2c0 · a14e2c0
1 parent b77046f
commit a14e2c0
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/components/Input/CurrencyInput/CurrencyInput.tsx b/src/components/Input/CurrencyInput/CurrencyInput.tsx
@@ -41,6 +41,8 @@ export const CurrencyInput = forwardRef<HTMLInputElement, Props>(
       if (props.value === undefined && props.defaultValue !== undefined) {
         formatValue(formatCurrency(props.defaultValue))
       }
+      // when component did mount
+      // eslint-disable-next-line react-hooks/exhaustive-deps
     }, [])
 
     useEffect(() => {
@@ -53,7 +55,7 @@ export const CurrencyInput = forwardRef<HTMLInputElement, Props>(
           formatValue(formatCurrency(innerRef.current.value))
         }
       }
-    }, [isFocused])
+    }, [isFocused, props.value, formatValue])
 
     const handleFocus = (e: FocusEvent<HTMLInputElement>) => {
       setIsFocused(true)