Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add necessary dependencies of hooks in CurrencyInput #906

Merged
merged 3 commits into from
Aug 4, 2020

Conversation

wmoai
Copy link
Contributor

@wmoai wmoai commented Jul 28, 2020

Related URL

#878

Overview

Adding dependencies of hooks, or suppressing react-hooks/exhaustive-deps rule

What I did

  • add normal deps of hooks
  • add comment to disable eslint rule

Capture

@wmoai wmoai requested a review from a team as a code owner July 28, 2020 06:52
@wmoai wmoai self-assigned this Jul 28, 2020
@wmoai wmoai requested review from diescake and im36-123 and removed request for a team July 28, 2020 06:52
@reg-suit
Copy link

reg-suit bot commented Jul 28, 2020

✨✨ That's perfect, there is no visual difference! ✨✨

Check out the report here.

@netlify
Copy link

netlify bot commented Jul 28, 2020

Deploy preview for smarthr-ui ready!

Built with commit dcfef6f

https://deploy-preview-906--smarthr-ui.netlify.app

@ouji-miyahara ouji-miyahara requested review from AtsushiM and removed request for diescake August 3, 2020 07:11
Copy link
Member

@AtsushiM AtsushiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wmoai wmoai merged commit a14e2c0 into master Aug 4, 2020
@wmoai wmoai deleted the fix-hooks-deps branch August 4, 2020 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants