Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add darkenAmount argument to hoverColor #950

Merged
merged 2 commits into from Nov 2, 2020

Conversation

Tokky0425
Copy link
Member

Related URL

Overview

  • added darkenAmount as the second argument to hoverColor so it can accept 0.15 as well.

@Tokky0425 Tokky0425 requested a review from a team as a code owner August 18, 2020 06:58
@Tokky0425 Tokky0425 requested review from diescake and MRTAFU and removed request for a team August 18, 2020 06:58
@reg-suit
Copy link

reg-suit bot commented Aug 18, 2020

✨✨ That's perfect, there is no visual difference! ✨✨

Check out the report here.

@netlify
Copy link

netlify bot commented Aug 18, 2020

Deploy preview for smarthr-ui ready!

Built with commit a7baaf3

https://deploy-preview-950--smarthr-ui.netlify.app

@Tokky0425 Tokky0425 merged commit 7d78586 into master Nov 2, 2020
@Tokky0425 Tokky0425 deleted the features/hover-color-darken-amount branch November 2, 2020 07:15
AtsushiM added a commit that referenced this pull request Nov 16, 2020
* fix: change to add aria-label to icon (#1110)

* chore(deps): update dependency @types/react-dom to ^16.9.9 (#1113)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency eslint to ^7.12.1 (#1114)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency ts-jest to ^26.4.3 (#1098)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency typescript to ^4.0.5 (#1115)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update babel monorepo (#1077)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update storybook monorepo to ^6.0.28 (#1117)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency lint-staged to ^10.5.1 (#1118)

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Masakatsu Tokita <lily.yarn.5@gmail.com>

* fix: change the minimum value of from props in the calendar component (#1122)

* fix: change the minimum value of from props in the calendar component

* test: fix calendar test

* feat: add darkenAmount argument to hoverColor method (#950)

* fix:  invalid html width attribute (#1105)

* feat: add "from" and "to" props to DatePicker component (#1123)

* fix: make StatusLabel vertical center alignment  (#879)

* fix: improve StatusLabel style

* test: update snapshot

* chore: reset css on storybook (SHRUI-163) (#1108)

* chore: add styled-reset

* chore: add reset css toolbar on storybook

* fix: DatePicker bugs (#1091)

* fix: fix portal container

* fix: fix handling of value prop

* chore(deps): update dependency mem to v8 (#1055)

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: wmoai <wmoaism@gmail.com>

* chore(deps): update dependency jest to ^26.6.3 (#1131)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency ts-loader to ^8.0.10 (#1133)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency @babel/helper-compilation-targets to ^7.12.5 (#1129)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency styled-reset to ^4.3.0 (#1135)

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Shiho Ishitoko <cidermitaina@gmail.com>

* fix: add box-sizing: border-box to textarea (#1060)

fix: add semicolon

Co-authored-by: Yuta YAMAMOTO <yuta.yamamoto@yuta.yamamoto>

* chore(deps): update dependency storycap to v3 (#1014)

* chore(deps): update dependency storycap to v3

* chore: add puppeteer

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: wmoai <wmoaism@gmail.com>

* feat: add border style to MessageDialog (#1059)

Co-authored-by: wmoai <wmoaism@gmail.com>

* docs: add readme for flash-message (#1062)

* docs: add readme for flash-message

* fix: update FlashMessage README

* feat: change the attribute of radius (#1080)

* feat: change the attribute of radius to classname

* feat: apply transient props

* fix: change theme props to transient props (#1081)

Co-authored-by: Shiho Ishitoko <cidermitaina@gmail.com>

* fix: pass undefined to accept instead of blank string (#1121)

Co-authored-by: Shiho Ishitoko <cidermitaina@gmail.com>

* Fix footer color to brand color  (#814)

* fix: change Footer color to Brand Color

* chore: remove HEADER_GREEN from palette

Co-authored-by: shota takata <36581513+im36-123@users.noreply.github.com>
Co-authored-by: Shiho Ishitoko <cidermitaina@gmail.com>

* fix: add aria-describedby (#1137)

* fix: shifting of index when IndexNav's ListItem is inserted into a new line (#1138)

* chore(deps): update dependency styled-components to ^5.2.1 (#1119)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore: adjust input size to be same with wrapper (#1139)

* chore(deps): update dependency prettier-config-smarthr to v1 (#1120)

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: negiandleek <youya66.official@gmail.com>

* chore(deps): update dependency puppeteer to ^5.4.1 (#1144)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency styled-reset to ^4.3.1 (#1145)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency ts-jest to ^26.4.4 (#1132)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency ts-loader to ^8.0.11 (#1146)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

* chore(deps): update dependency dayjs to ^1.9.6 (#1130)

Co-authored-by: Renovate Bot <bot@renovateapp.com>

Co-authored-by: Shiho Ishitoko <cidermitaina@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Masakatsu Tokita <lily.yarn.5@gmail.com>
Co-authored-by: nabeliwo <hiroki.c.watanabe@gmail.com>
Co-authored-by: KANAMORI Yu <y.kinmori@gmail.com>
Co-authored-by: wmoai <wmoaism@gmail.com>
Co-authored-by: Yuta Yamamoto <ftbae1@gmail.com>
Co-authored-by: Yuta YAMAMOTO <yuta.yamamoto@yuta.yamamoto>
Co-authored-by: Shinichi Kogiso <kuusai1998@gmail.com>
Co-authored-by: shota takata <36581513+im36-123@users.noreply.github.com>
Co-authored-by: negiandleek <youya66.official@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants