Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bump core dependencies to angular 8 #73

Merged
merged 3 commits into from
Oct 30, 2019
Merged

Feature/bump core dependencies to angular 8 #73

merged 3 commits into from
Oct 30, 2019

Conversation

bbortt
Copy link
Collaborator

@bbortt bbortt commented Aug 29, 2019

This PR contains the following changes:

  • Initial @angular/cli:^8.0.3 update by @DenisaSurdu
    • Squashed and signed commits into current
  • Bumping project dependencies to @angular/cli:^2.4.0 compatible versions
  • Bumping peer dependencies to @angular/cli:^2.4.0 compatible versions
  • Updating angular.json with compatible tags
    • - "architect" + "targets"

Because of the scripts-tag in package.json it seems like the primary package manager is yarn. Therefore I reconfigured the angular.json and removed the package-lock.json as well.

commit 5e8112d
Author: ovidiu <bovidiu87@gmail.com>
Date:   Fri Jun 28 14:08:00 2019 +0100

    Updated Angular Material to v 8

commit d18faee
Author: ovidiu <bovidiu87@gmail.com>
Date:   Fri Jun 28 14:04:17 2019 +0100

    Upgraded Typescript to v 3.4 and upgraded Angular to Angular 8

commit a98c16c
Author: ovidiu <bovidiu87@gmail.com>
Date:   Fri Jun 28 13:53:00 2019 +0100

    All packages update
@bbortt bbortt mentioned this pull request Aug 29, 2019
@bbortt
Copy link
Collaborator Author

bbortt commented Aug 29, 2019

to: @kuhnroyal
cc: @DenisaSurdu
fixes: #69

Copy link

@maertz maertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully in our project. Thanks for this PR.

@intellix
Copy link

intellix commented Oct 11, 2019

Good to merge? Angular 9 is almost upon us. Will see what I get testing it:

  • polyfills.ts is out of date

@bbortt
Copy link
Collaborator Author

bbortt commented Oct 14, 2019

* polyfills.ts is out of date

no wonder, if nobody merges this within years :D @intellix

@Roen00
Copy link

Roen00 commented Oct 28, 2019

Hello, any progress on this issue? What prevents the merge?

@bbortt bbortt mentioned this pull request Oct 30, 2019
@bbortt bbortt merged commit 0ceb1d6 into kuhnroyal:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants