Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: changed Chakra UI to dark theme #859

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

flohoch
Copy link
Contributor

@flohoch flohoch commented Mar 12, 2024

No description provided.

@flohoch flohoch requested a review from philprime March 12, 2024 16:33
@flohoch flohoch self-assigned this Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 94 lines in your changes are missing coverage. Please review.

Project coverage is 2.94%. Comparing base (670f7a8) to head (795a3f6).
Report is 1 commits behind head on main.

Files Patch % Lines
pages/orgs/[orgId]/apps/[appId]/messages/index.tsx 0.00% 11 Missing ⚠️
styles/appColors.ts 0.00% 9 Missing ⚠️
pages/orgs/[orgId]/apps/[appId]/messages/new.tsx 0.00% 8 Missing ⚠️
pages/orgs/[orgId]/apps/[appId]/settings.tsx 0.00% 8 Missing ⚠️
pages/profile.tsx 0.00% 8 Missing ⚠️
pages/resetPassword.tsx 0.00% 7 Missing ⚠️
components/AuthForm.tsx 0.00% 6 Missing ⚠️
pages/orgs/[orgId]/apps/new.tsx 0.00% 6 Missing ⚠️
pages/reset.tsx 0.00% 6 Missing ⚠️
components/Navbar.tsx 0.00% 5 Missing ⚠️
... and 9 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #859      +/-   ##
========================================
- Coverage   2.96%   2.94%   -0.02%     
========================================
  Files        131     133       +2     
  Lines       2937    2952      +15     
  Branches     303     303              
========================================
  Hits          87      87              
- Misses      2848    2863      +15     
  Partials       2       2              
Flag Coverage Δ
unittests 2.94% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philprime
Copy link
Contributor

I think we should do something about "Create new account" and "forgot password" being unreadable with that low contrast between purple font color and black background

image

CC @copieman

@philprime philprime changed the title Chakra UI theme style: added Chakra UI theme Mar 13, 2024
@philprime
Copy link
Contributor

Same applies to gray on black

image

@philprime
Copy link
Contributor

Maybe the date picker should also use the dark theme

image

@philprime
Copy link
Contributor

In general the low contrast between text and background takes a big toll on usability.
There is no more distinction between placeholders and the acutal entered text in the textfields.

image

Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion these changes are not an improvement

@philprime philprime changed the title style: added Chakra UI theme style: changed Chakra UI to dark theme Mar 13, 2024
@philprime
Copy link
Contributor

@copieman @flohoch it might be a good idea to look at the colors on a lower-/mid-quality monitor. The contrast might be good on an iMac or on an Apple Studio display, but when I tested it I used my "normal" Samsung Monitors and it was sunny inside and outside

@copieman
Copy link
Contributor

Changes @flohoch

  • Button Text like create new Account etc. get the new color "light purple" #BC92E4 (it's WCAG compliant)
  • The Text Color #8E8E93 that I selected is also WCAG compliant, so check if in the second picture it's rightly chosen
  • Date Picker dark if possible of course, makes sense
  • Text, when typed in should be white #FFFFFF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants