Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): add PURE annotation for DCE #48

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Conversation

kuldeepkeshwar
Copy link
Owner

  • Prepend #PURE comment to help minifiers with dead code elimination (=DCE)
  • Remove StyleSheetContext from styled api
  • Refactored website(sidebar)

@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2020

🦋 Changeset is good to go

Latest commit: 3611aa9

We got this.

This PR includes changesets to release 6 packages
Name Type
babel-plugin-filbert Patch
@filbert-js/core Patch
@filbert-js/website Patch
gatsby-plugin-filbert Patch
benchmarks-filbert Patch
benchmarks-performance Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@todo
Copy link

todo bot commented Jul 28, 2020

') {

if (item.name !== 'Todo') {
if (agg[item.group]) {
agg[item.group].push(item);
} else {
agg[item.group] = [item];
}


This comment was generated by todo based on a Todo comment in 989200d in #48. cc @kuldeepkeshwar.

@vercel
Copy link

vercel bot commented Jul 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kuldeepkeshwar/filbert-js/q2isfnjy5
✅ Preview: https://filbert-js-git-pure-annotation.kuldeepkeshwar.vercel.app

@todo
Copy link

todo bot commented Jul 28, 2020

') {

if (item.name !== 'Todo') {
if (agg[item.group]) {
agg[item.group].push(item);
} else {
agg[item.group] = [item];
}


This comment was generated by todo based on a Todo comment in 3611aa9 in #48. cc @kuldeepkeshwar.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2020

Size Change: -106 B (0%)

Total Size: 15.8 kB

Filename Size Change
packages/core/dist/index.es.js 1.24 kB -39 B (3%)
packages/core/dist/index.js 1.24 kB -35 B (2%)
packages/core/dist/index.umd.js 1.32 kB -32 B (2%)
ℹ️ View Unchanged
Filename Size Change
packages/autoprefixer/dist/index.es.js 176 B 0 B
packages/autoprefixer/dist/index.js 167 B 0 B
packages/autoprefixer/dist/index.umd.js 262 B 0 B
packages/browser-stylesheet/dist/index.es.js 518 B 0 B
packages/browser-stylesheet/dist/index.js 506 B 0 B
packages/browser-stylesheet/dist/index.umd.js 587 B 0 B
packages/css-ast/dist/index.es.js 570 B 0 B
packages/css-ast/dist/index.js 568 B 0 B
packages/css-ast/dist/index.umd.js 641 B 0 B
packages/css-parser/dist/index.es.js 439 B 0 B
packages/css-parser/dist/index.js 431 B 0 B
packages/css-parser/dist/index.umd.js 513 B 0 B
packages/server-stylesheet/dist/index.es.js 842 B 0 B
packages/server-stylesheet/dist/index.js 852 B 0 B
packages/server-stylesheet/dist/index.umd.js 956 B 0 B
packages/style-sheet-context/dist/index.es.js 203 B 0 B
packages/style-sheet-context/dist/index.js 232 B 0 B
packages/style-sheet-context/dist/index.umd.js 321 B 0 B
packages/stylesheet/dist/index.es.js 600 B 0 B
packages/stylesheet/dist/index.js 607 B 0 B
packages/stylesheet/dist/index.umd.js 681 B 0 B
packages/theming/dist/index.es.js 146 B 0 B
packages/theming/dist/index.js 173 B 0 B
packages/theming/dist/index.umd.js 257 B 0 B
packages/types/dist/index.es.js 232 B 0 B
packages/types/dist/index.js 210 B 0 B
packages/types/dist/index.umd.js 305 B 0 B

compressed-size-action

@kuldeepkeshwar kuldeepkeshwar merged commit 002e3f5 into master Jul 28, 2020
@todo todo bot mentioned this pull request Jul 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant