[pull] master from paulirish:master #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Default to package.json * Fix some tests
Bump ts to 2.3, fixes
* fix for Cannot find module path/to/package.json exception * docs stuff * verify if cli provided url doesn't cause any Error * improve test * Revert fs function * Normalize test structure * add test for not passing parameter * Update cli.js Workaround yargs default option limitation. If the option has a default option it will always be set regardless of whether it has been called. Must test against undefined (flag not called from command line) and then if against the actual value, if no value set -> default to package.json (default parameter in the getConfigFromFile function) Submitted issue yargs repo as yargs/yargs#875
* Create issue_template.md * Update issue_template.md
Clarified config flag usage.
Adds chrome-launcher Bumps lighthouse version to v2.1
Updates lighthouse's version to v2.1 Adds chrome-launcher entry
WIP still does not work.
Adds chrome-launcher typing to Pwmetrics.launcher property and methods for type correctness.
Save chrome-launcher auto-generated ports to utilize it when starting lighthouse.
…-for-charts Ignore unrecorded timings when printing charts
* feat: showOutput option & log function * logger class * doc update
* updates for using lighthouse v3 * bump node support, improve travis * bum LH to commit with _Crdp fix * improve travis * get back to old friends metrics * improve gulp example, get rid of throwing if expectation error happened * use logger for LH runner * check expectations base on median results
filter results in case of errors
docs: fix the metrics sample in readme.md
fix: display warnings even if no errors
* fix: exit code is 1 when expectations are not fulfilled * feat: add the --fail-on-error/failOnError flag
* refactor: outputData as a proper PWMetrics method * feat: use micro-promisify in writeToDisk
This allows to require metrics easier than before by doing:
```
const metrics = require('pwmetrics/lib/metrics');
// {
// TTFCP: "firstContentfulPaint",
// TTFMP: "firstMeaningfulPaint",
// TTFCPUIDLE: "firstCPUIdle",
// TTI: "interactive",
// SI: "speedIndex"
// }
```
Contrary to the current way:
```
const metrics = require('pwmetrics/lib/metrics/metrics');
// {
// METRICS: {
// TTFCP: "firstContentfulPaint",
// TTFMP: "firstMeaningfulPaint",
// TTFCPUIDLE: "firstCPUIdle",
// TTI: "interactive",
// SI: "speedIndex"
// }
// }
```
The `readme.md` and `gulpfile.js` files have been updated too.
feat(lib): exporting metrics by default
use a semi symbol (following ASI rules)
update scripts
fixes timings error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )