-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples comparing ts-jest and Jest setups #118
Conversation
The Jest example works with vscode The ts-jest example does not work with vscode
@tkrotoff thanks! |
I tested the examples from the command line and they worked there. I think adding these in despite the issue with vscode would be better than not adding them. |
Well, before merging this, I wanted you to review it and discuss it with you and see how to make ts-jest work with vscode debugger. If you check carefully the examples, I don't see any benefit for using ts-jest over Jest directly (with a I though ts-jest would allow me to remove the Overall, I don't understand what problem ts-jest is trying to solve and the readme does not help on this. Edit, clarification: |
@tkrotoff ok. I misunderstood what you were trying to say. The reason I created ts-jest was solely because I wanted sourcemap support for tests written in typescript. The only way to see this issue is by introducing a bug in a typescript file in a part that is covered by a test. Without ts-jest, at least when I had tried, the tests failed with line numbers based on the transpiled javascript file and not the original typescript files. Does this bring some clarity? As for vscode, even though that is what I use, integration with it wasn't a priority for me. Neither was coverage, for that matter. Should I now revert this merge? |
Looking at this again, merging was probably hastily done. I'll revert this now and look at this again later |
I see, that matches the README.md line:
Approaches to solve the problem:
Edit: |
Following this discussion
The Jest example works with vscode debugger
The ts-jest example does not work with vscode debugger - I don't know how to make it work in an elegant way