Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(utils): revert path.join and add check on prefix ends with / #1989

Merged
merged 1 commit into from Sep 29, 2020
Merged

fix(utils): revert path.join and add check on prefix ends with / #1989

merged 1 commit into from Sep 29, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Sep 28, 2020

Summary

Closes #1982

Test plan

Adjusted unit tests and e2e tests

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

coveralls commented Sep 28, 2020 •
edited

Pull Request Test Coverage Report for Build 6001

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 93.248%
Totals Coverage Status
Change from base Build 6000: 0.03%
Covered Lines: 1139
Relevant Lines: 1173
💛 - Coveralls

@ahnpnl ahnpnl marked this pull request as ready for review September 29, 2020 07:20
@ahnpnl ahnpnl merged commit 3d9035b into kulshekhar:master Sep 29, 2020
@ahnpnl ahnpnl deleted the fix-test-utils branch September 29, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking changes: pathsToModuleNameMapper resolve path mapping with path.join
3 participants
@ahnpnl @coveralls @kulshekhar