Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): resolve `.babelrc` file before attempting to read it #2071

Merged
merged 1 commit into from Oct 26, 2020

Conversation

@ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Oct 26, 2020

Summary

Closes #2064

Test plan

Added unit test, green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner Oct 26, 2020
@coveralls
Copy link

@coveralls coveralls commented Oct 26, 2020

Pull Request Test Coverage Report for Build 6318

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 93.658%

Totals Coverage Status
Change from base Build 6315: 0.003%
Covered Lines: 1019
Relevant Lines: 1048

💛 - Coveralls
@ahnpnl ahnpnl force-pushed the ahnpnl:fix-babelrc branch from c149f22 to 1c0b9b3 Oct 26, 2020
@ahnpnl ahnpnl changed the title fix(config): resolve `.babelrc` before attempting to read it fix(config): resolve `.babelrc` file before attempting to read it Oct 26, 2020
@ahnpnl ahnpnl merged commit 681bfef into kulshekhar:master Oct 26, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
coverage/coveralls Coverage increased (+0.003%) to 93.658%
Details
@ahnpnl ahnpnl deleted the ahnpnl:fix-babelrc branch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.