Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): allow disable sourcemap #2544

Merged
merged 1 commit into from Apr 29, 2021

Conversation

@ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 29, 2021

Summary

This is the functionality we had in the past before 23.10 but was lost after 23.10. This PR is to bring it back.

The original request was #469

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

By default, ts-jest will use sourceMap option from test tsconfig. If users want to have sourcemap on, they need to either remove sourceMap from tsconfig or set sourceMap: true

Other information

N.A.

@ahnpnl ahnpnl force-pushed the allow-disable-sourcemaps branch from c035ba2 to 0daa91f Apr 29, 2021
@ahnpnl ahnpnl added this to the ts-jest v27 milestone Apr 29, 2021
@coveralls
Copy link

@coveralls coveralls commented Apr 29, 2021

Pull Request Test Coverage Report for Build 796171752

  • 0 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 93.936%

Totals Coverage Status
Change from base Build 795301809: -0.01%
Covered Lines: 1004
Relevant Lines: 1034

💛 - Coveralls

Loading

@coveralls
Copy link

@coveralls coveralls commented Apr 29, 2021

Pull Request Test Coverage Report for Build 796171752

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 93.936%

Totals Coverage Status
Change from base Build 795301809: -0.01%
Covered Lines: 1004
Relevant Lines: 1034

💛 - Coveralls

Loading

@ahnpnl ahnpnl marked this pull request as ready for review Apr 29, 2021
@ahnpnl ahnpnl requested a review from kulshekhar as a code owner Apr 29, 2021
@ahnpnl ahnpnl merged commit 47da6ad into kulshekhar:master Apr 29, 2021
15 checks passed
Loading
@ahnpnl ahnpnl deleted the allow-disable-sourcemaps branch Apr 29, 2021
@eternalmatt
Copy link

@eternalmatt eternalmatt commented Oct 5, 2021

I did not appreciate this breaking change.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants