Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): throw type check error in ESM mode with reject #3618

Merged
merged 1 commit into from Jun 7, 2022

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Jun 6, 2022

Summary

Fixes #3507

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl changed the title fix(legacy): trow type check error in ESM mode with reject fix(legacy): throw type check error in ESM mode with reject Jun 6, 2022
@ahnpnl ahnpnl force-pushed the fix-esm-hang-type-check branch from ff1fd7c to a3de249 Compare Jun 6, 2022
@coveralls
Copy link

coveralls commented Jun 6, 2022

Pull Request Test Coverage Report for Build 2450543666

  • 15 of 25 (60.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 94.004%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/legacy/ts-jest-transformer.ts 6 7 85.71%
src/legacy/compiler/ts-compiler.ts 8 17 47.06%
Totals Coverage Status
Change from base Build 2450409176: -0.8%
Covered Lines: 1117
Relevant Lines: 1154

💛 - Coveralls

@ahnpnl ahnpnl marked this pull request as ready for review Jun 6, 2022
@ahnpnl ahnpnl requested a review from kulshekhar as a code owner Jun 6, 2022
@ahnpnl ahnpnl force-pushed the fix-esm-hang-type-check branch from a3de249 to 0e40751 Compare Jun 6, 2022
Repository owner deleted a comment from coveralls Jun 6, 2022
@ahnpnl ahnpnl merged commit 7dd01ff into kulshekhar:main Jun 7, 2022
16 checks passed
@ahnpnl ahnpnl deleted the fix-esm-hang-type-check branch Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants