Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jest-util as dependency #380

Merged
merged 2 commits into from
Dec 1, 2017
Merged

Remove jest-util as dependency #380

merged 2 commits into from
Dec 1, 2017

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Nov 30, 2017

It's not used

image

Not sure why it was added in #109

@SimenB
Copy link
Contributor Author

SimenB commented Nov 30, 2017

ergh, made the change on github. Will push commit with updated lockfile.

EDIT: Running yarn locally didn't change the lockfile (which makes sense)

@kulshekhar
Copy link
Owner

@SimenB
Copy link
Contributor Author

SimenB commented Nov 30, 2017

Oops, I meant to remove config, not util (as can be seen in the commit message :P)

Bah, I'm confusing myself. jest-util is supposed to go, not config.

@thymikee
Copy link
Contributor

@SimenB GitHub search is retarded, happened to me recently that it too didn't find direct reference to what I searched

@SimenB
Copy link
Contributor Author

SimenB commented Nov 30, 2017

I grepped locally now.

$ rg jest-util
yarn.lock
2043:    jest-util "^21.2.1"
2066:    jest-util "^21.2.1"
2088:    jest-util "^21.2.1"
2096:    jest-util "^21.2.1"
2174:    jest-util "^21.2.1"
2193:    jest-util "^21.2.1"
2212:jest-util@^21.0.0, jest-util@^21.2.1:
2214:  resolved "https://registry.yarnpkg.com/jest-util/-/jest-util-21.2.1.tgz#a274b2f726b0897494d694a6c3d6a61ab819bb78"
3657:    jest-util "^21.0.0"

package.json
76:    "jest-util": "^21.2.1",

tests/deprecated-tsconfig/yarn.lock
963:    jest-util "^20.0.3"
1007:    jest-util "^20.0.3"
1015:    jest-util "^20.0.3"
1102:    jest-util "^20.0.3"
1115:    jest-util "^20.0.3"
1119:jest-util@^20.0.3:
1121:  resolved "https://registry.yarnpkg.com/jest-util/-/jest-util-20.0.3.tgz#0c07f7d80d82f4e5a67c6f8b9c3fe7f65cfd32ad"

@SimenB SimenB changed the title Remove jest-config as dependency Remove jest-util as dependency Nov 30, 2017
@kulshekhar
Copy link
Owner

I don't know what made me think it was jest-config. Anyway, thanks for the PR :)

kulshekhar
kulshekhar previously approved these changes Nov 30, 2017
@kulshekhar
Copy link
Owner

kulshekhar commented Nov 30, 2017

@SimenB Could you also:

  • bump the version patch in package.json so that this can be published right away
  • update the AUTHORS file with your name/email in alphabetical order?

@SimenB
Copy link
Contributor Author

SimenB commented Nov 30, 2017

I don't know what made me think it was jest-config

I had it wrong the first time - I just force pushed 🙂

@kulshekhar kulshekhar merged commit 41206f5 into kulshekhar:master Dec 1, 2017
@SimenB SimenB deleted the patch-1 branch December 1, 2017 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants